chore: one time manual docker images update for shared-deps 3.21.0 release #2334
Conversation
.cloudbuild/cloudbuild.yaml
Outdated
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| timeout: 7200s # 2 hours | |||
| substitutions: | |||
| _SHARED_DEPENDENCIES_VERSION: '3.20.0' # {x-version-update:google-cloud-shared-dependencies:released} | |||
| _SHARED_DEPENDENCIES_VERSION: '3.21.0' # {x-version-update:google-cloud-shared-dependencies:released} | |||
There was a problem hiding this comment.
Could you remind me why this one is released but the above two are current?
There was a problem hiding this comment.
The cloudbuild.yaml file is used for the Cloud Build trigger that actually publishes the docker images with every release whereas the cloudbuild-test-*.yaml files are mainly for verifying the docker images locally (therefore, they're also updated to SNAPSHOT). Since publishing the docker images for SNAPSHOT versions would be redundant, we only update cloudbuild when a release takes place.
There was a problem hiding this comment.
That being said, we only trigger the cloud build job when a specific github tag is pushed so the docker image will only be pushed when a non-SNAPSHOT release PR is merged. The main purpose of the versioning is mostly to reduce the cognitive load in tracking which image tags are pushed without having to look at the cloud build trigger configurations.
There was a problem hiding this comment.
@burkedavison As discussed offline, modified the use of released to current. This will mitigate the risk of a manual trigger of the cloud build job accidentally overriding a published image.
|
|
Preparing docker images for #2290. Similar to the observations in googleapis/java-shared-config#730, release-please doesn't update these files despite the following configs being applied:
x-version-update:<artifact-name>:released.cloudbuild/yamls files toextraFilesparameter inrelease-please.yaml(line)These files were updated after the the release PR was opened. In the case of java-shared-config, the update to these extra files didn't happen until a new release PR was opened. Created a follow-up task to verify the automation in the next release #2327.