Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify update of cloudbuild-test-*.yaml files in upcoming release #730

Closed
mpeddada1 opened this issue Dec 7, 2023 · 4 comments
Closed

Verify update of cloudbuild-test-*.yaml files in upcoming release #730

mpeddada1 opened this issue Dec 7, 2023 · 4 comments
Labels
release blocking Required feature/issue must be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@mpeddada1
Copy link
Contributor

mpeddada1 commented Dec 7, 2023 •
edited
Loading

Part of #691

The release-please.yml file was updated to include these files (#728) while this release PR was already open . However, add the release-please:force-run label to PR 728 and 727 (as documented in https://github.com/googleapis/release-please/blob/main/README.md#step-3-rerun-release-please) and closing and re-opening the release PR didn't do the trick.

On the other hand, adding the cloudbuild.yaml file to the extra-files field in release-please.yaml with an inline annotation x-version-update:<artifact-name>:released worked.

Reference for both settings:
@mpeddada1 mpeddada1 added release blocking Required feature/issue must be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern. labels Dec 7, 2023
@suztomo
Copy link
Member

suztomo commented Dec 7, 2023

The document you referenced has "Updating arbitrary YAML files" section.

image

I don't see #728 followed this.

@mpeddada1
Copy link
Contributor Author

[Update] It looks like the update to release-please.yml is working now? #731

@suztomo
Copy link
Member

suztomo commented Dec 8, 2023

Nice. Then check with next Release Please pull request for non-snapshot version.

@mpeddada1
Copy link
Contributor Author

Verified that it is being updated for non-snapshot versions as well: #733. Closing issue.

This was referenced Jan 2, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release blocking Required feature/issue must be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suztomo @mpeddada1