fix(spring): update hasRestOption to exclude services with no rest-supported methods

[emmileaf]

This PR aligns the spring generator with main branch changes from #1117. I copied the relevant isSupportedByTransport(Transport.REST) logic as a quick fix instead of cherry-picking the commits, since the branches have diverged a bit since the monorepo migration.

Future note: as part of migrating this spring generator code away from its separate branch and depending on the gapic generator jar, I'd like to revisit this logic to call the corresponding helpers in gapic-generator-java main.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

76.5% Coverage
0.0% Duplication

[blakeli0]

LGTM. Let's try to get this in first and unblock the release, can you please add a test for it in a separate PR? So that we know this functionality is not breaking when we do the migration.

[emmileaf]

LGTM. Let's try to get this in first and unblock the release, can you please add a test for it in a separate PR? So that we know this functionality is not breaking when we do the migration.

Sounds good, will merge and follow-up on this since the existing golden tests don’t cover for the additional REST-related logic.

@lqiu96 I saw that you had added wicked.proto as part of your changes, and was wondering if you could help me understand additional context on this test service?

[lqiu96]

LGTM. Let's try to get this in first and unblock the release, can you please add a test for it in a separate PR? So that we know this functionality is not breaking when we do the migration.

Sounds good, will merge and follow-up on this since the existing golden tests don’t cover for the additional REST-related logic.

@lqiu96 I saw that you had added wicked.proto as part of your changes, and was wondering if you could help me understand additional context on this test service?

The wicked.proto was intended to be part of the showcase tests to cover the new REST method generation logic (i.e. a generic proto that had non-REST enabled or eligible RPCs in a service). Showcase testing is primarily used to cover the functionality of a generated client library's behavior (i.e. having the generated library hit a mock server and validating the behavior) whereas this proto was primarily used to test the generator's generation behavior. There was some pushback so there is an "extended" framework called gapic-showcase-extended where I've put this proto. The extended showcase module is able to test additional stuff like generator's generation behavior + anything else we may need in the future.

[emmileaf]

@lqiu96 Gotcha, thanks for the explanation. I think I'll try to re-use as much as this unit testing setup as I can for testing generation behaviour on the spring side as well. Really appreciate all the work you've already laid out here!

[lqiu96]

@emmileaf Sounds good! There may be a few lingering issues with the showcase-extended module. Let me know and I can try to help resolve them