fix(spring): update hasRestOption to exclude services with no rest-su…

…pported methods (#1343)
googleapis · Feb 9, 2023 · 3f5db4d · 3f5db4d
1 parent 26c2e12
commit 3f5db4d
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java b/src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
@@ -110,7 +110,17 @@ public GapicClass generate(GapicContext context, Service service) {
 
     Expr thisExpr = ValueExpr.withValue(ThisObjectValue.withType(dynamicTypes.get(className)));
     Transport transport = context.transport();
-    boolean hasRestOption = transport.equals(Transport.GRPC_REST);
+    // TODO(emmwang): this condition is adapted from latest gapic-generator-java changes as part of
+    // https://github.com/googleapis/gapic-generator-java/issues/1117, but should be updated to use
+    // the gapic-implemented helpers once spring generator code is migrated.
+    boolean hasRestSupportedMethod =
+        service.methods().stream()
+            .anyMatch(
+                x ->
+                    x.httpBindings() != null
+                        && x.stream() != Method.Stream.BIDI
+                        && x.stream() != Method.Stream.CLIENT);
+    boolean hasRestOption = transport.equals(Transport.GRPC_REST) && hasRestSupportedMethod;
     String serviceSettingsMethodName = JavaStyle.toLowerCamelCase(service.name()) + "Settings";
 
     ClassDefinition classDef =