Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving ProtobufMessageFeature native image configuration to gax #1323

Closed
mpeddada1 opened this issue Sep 9, 2022 · 2 comments
Closed

Consider moving ProtobufMessageFeature native image configuration to gax #1323

mpeddada1 opened this issue Sep 9, 2022 · 2 comments
Assignees
@mpeddada1
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mpeddada1
Copy link
Contributor

mpeddada1 commented Sep 9, 2022 •
edited
Loading

Currently java-compute brings in gax-grpc for the purpose of bringing in ProtobufMessageFeature. The ProtobufMessageFeature class is used to register reflection configurations for all the sub-classes of com.google.protobuf.GeneratedMessageV3 which is used by generated client libraries.

However, adding a dependency on gax-grpc can cause confusion especially when a library (such a java-compute) is REST-based and has also resulted in some unintended behavior (googleapis/java-compute#721) during native image compilation.

TODO:
The dependency on gax-grpc needs to be removed from java-compute once this change is made, released and gax is upgraded in the libraries

cc: @blakeli0 @suztomo
@mpeddada1 mpeddada1 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 9, 2022
@mpeddada1 mpeddada1 self-assigned this Sep 9, 2022
@ddixit14 ddixit14 transferred this issue from googleapis/gax-java Feb 8, 2023
suztomo pushed a commit that referenced this issue Mar 21, 2023
@gcf-owl-bot
chore(java): update variable name to api_shortname in README template (…
5fa42d5 
…#1323) (#671)
@mpeddada1
Copy link
Contributor Author

Obsolete as of #1892. Static reflect-config.json are now generated for all GAPICs

@mpeddada1 mpeddada1 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
@blakeli0 blakeli0 mentioned this issue Sep 21, 2023
Merged
@blakeli0
Copy link
Collaborator

Thanks @mpeddada1! To follow up, I created googleapis/google-cloud-java#9864 to remove gax-grpc from Compute, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpeddada1 mpeddada1

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blakeli0 @mpeddada1 and others