This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
fix(java): exclude unused dependencies from gax-grpc #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
mpeddada1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
approved these changes
Aug 31, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.1](v1.12.0...v1.12.1) (2022-09-15) ### Bug Fixes * **java:** Exclude unused dependencies from gax-grpc ([#721](#721)) ([4da7a1f](4da7a1f)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#724](#724)) ([2b41e83](2b41e83)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#727](#727)) ([63bfcce](63bfcce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to meltsufin/monorepo-experiments
that referenced
this pull request
Sep 17, 2022
🤖 I have created a release *beep* *boop* --- ## [1.12.1](googleapis/java-compute@v1.12.0...v1.12.1) (2022-09-15) ### Bug Fixes * **java:** Exclude unused dependencies from gax-grpc ([#721](googleapis/java-compute#721)) ([b6b4e15](googleapis/java-compute@b6b4e15)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#724](googleapis/java-compute#724)) ([374a16b](googleapis/java-compute@374a16b)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#727](googleapis/java-compute#727)) ([fc748b7](googleapis/java-compute@fc748b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gax-grpc contains some native-image configurations that are needed for native-image compilation to be successful (see #688). However, adding the gax-grpc dependency also transitively brings in it's own dependencies which are not required for either standard Java or native image users. This can result in some side effects including the one seen in googleapis/gax-java#1781. This PR excludes those dependencies to ensure that only the necessary code is brought in.
Reproducer: https://github.com/mpeddada1/test-gax/tree/main