Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sample): retry InternalServerError #329

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix(sample): retry InternalServerError #329

merged 1 commit into from
Mar 15, 2021

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Mar 15, 2021

fixes #321

@tmatsuo tmatsuo requested a review from anguillanneuf March 15, 2021 16:19
@tmatsuo tmatsuo requested a review from a team as a code owner March 15, 2021 16:19
@tmatsuo tmatsuo requested review from dinagraves and removed request for a team March 15, 2021 16:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2021
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 15, 2021
anguillanneuf
anguillanneuf approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

120s is good, because the sample times out after 90s anyway.

@anguillanneuf anguillanneuf merged commit 34c9b11 into googleapis:master Mar 15, 2021
anguillanneuf pushed a commit that referenced this pull request Mar 16, 2021
@anguillanneuf
fix(sample): retry InternalServerError (#329)
341fa19 
fixes #321
anguillanneuf added a commit that referenced this pull request Mar 30, 2021
@pradn @anguillanneuf
fix: Remove EXPERIMENTAL tag for ordering keys in publisher/client.py (…
b035b86 
…#324)

* Remove EXPERIMENTAL tag for ordering keys in publisher/client.py

* fix(sample): mark test flaky (#326)

* fix(sample): retry InternalServerError (#329)

fixes #321

Co-authored-by: Tianzi Cai <[email protected]>
Co-authored-by: Takashi Matsuo <[email protected]>
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@dinagraves dinagraves Awaiting requested review from dinagraves

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

samples.snippets.subscriber_test: test_update_dead_letter_policy failed
2 participants
@tmatsuo @anguillanneuf