Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove EXPERIMENTAL tag for ordering keys in publisher/client.py #324

Merged
merged 3 commits into from
Mar 30, 2021
Merged

docs: Remove EXPERIMENTAL tag for ordering keys in publisher/client.py #324

merged 3 commits into from
Mar 30, 2021

Conversation

pradn
Copy link
Contributor

@pradn pradn commented Mar 11, 2021

No description provided.

@pradn pradn requested a review from a team as a code owner March 11, 2021 18:55
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2021
@pradn pradn changed the title Remove EXPERIMENTAL tag for ordering keys in publisher/client.py fix: Remove EXPERIMENTAL tag for ordering keys in publisher/client.py Mar 11, 2021
@plamut
Copy link
Contributor

plamut commented Mar 12, 2021

Thanks for catching and addressing that.

I'm not entirely sure why the samples tests fail, is the PR branch based on the latest master? BTW, I also suggest merging this with #323, so that we don't end up with a seemingly duplicate entry in release notes.

@pradn pradn requested a review from a team as a code owner March 16, 2021 21:07
@pradn pradn requested review from dinagraves and removed request for a team March 16, 2021 21:07
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2021
@meredithslota meredithslota removed the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2021
@anguillanneuf anguillanneuf merged commit b035b86 into master Mar 30, 2021
@anguillanneuf anguillanneuf deleted the pradn-patch-5 branch March 30, 2021 20:51
@plamut plamut changed the title fix: Remove EXPERIMENTAL tag for ordering keys in publisher/client.py docs: Remove EXPERIMENTAL tag for ordering keys in publisher/client.py May 7, 2021
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinagraves dinagraves dinagraves approved these changes

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pradn @plamut @kamalaboulhosn @dinagraves @meredithslota @anguillanneuf @yoshi-kokoro