Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use new call syntax in subscriber docs #203

Merged
merged 2 commits into from
Sep 21, 2020
Merged

docs: use new call syntax in subscriber docs #203

merged 2 commits into from
Sep 21, 2020

Conversation

cguardia
Copy link
Contributor

@cguardia cguardia commented Sep 21, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Appropriate docs were updated (if necessary)

Fixes #198 🦕

@cguardia cguardia requested a review from a team as a code owner September 21, 2020 08:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2020
@cguardia cguardia requested a review from plamut September 21, 2020 08:15
plamut
plamut suggested changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, please fix.

Also nit (optional): We might want to use double quotes to be consistent with our linting rules and samples, and no spaces around = for kwargs. But again, it's a nit that you can choose to ignore.

docs/subscriber/index.rst Outdated Show resolved Hide resolved
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ff46bec into googleapis:master Sep 21, 2020
@cguardia cguardia mentioned this pull request Sep 21, 2020
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs have incorrect example for v2.0.0
2 participants
@cguardia @plamut