Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs have incorrect example for v2.0.0 #198

Closed
rvandegrift opened this issue Sep 17, 2020 · 2 comments · Fixed by #203
Closed

docs have incorrect example for v2.0.0 #198

rvandegrift opened this issue Sep 17, 2020 · 2 comments · Fixed by #203
Assignees
@cguardia
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.

Comments

@rvandegrift
Copy link

The examples in the documentation have not been updated for the changes described in [1].

[1] https://googleapis.dev/python/pubsub/latest/UPGRADING.html
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2020
@plamut
Copy link
Contributor

plamut commented Sep 18, 2020

@rvandegrift Which examples are you referring to, the one in the product documentation or in the library reference?

We'll happily fix that, thanks for the report!

@plamut plamut added the type: docs Improvement to the documentation for an API. label Sep 18, 2020
@rvandegrift
Copy link
Author

@plamut the library reference - sorry, I meant to include a link to the one that threw me off yesterday. It's here: https://googleapis.dev/python/pubsub/latest/subscriber/index.html#pulling-a-subscription-synchronously

cguardia added a commit to cguardia/python-pubsub that referenced this issue Sep 21, 2020
@cguardia
docs: use new call syntax in subscriber docs
e5177fa 
Refs googleapis#198
@cguardia cguardia mentioned this issue Sep 21, 2020
Merged
1 task
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 21, 2020
@cguardia
docs: use new call syntax in subscriber docs (#203)
ff46bec 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

- [X] Appropriate docs were updated (if necessary)

Fixes #198 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cguardia cguardia

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: use new call syntax in subscriber docs cguardia/python-pubsub
3 participants
@cguardia @rvandegrift @plamut