Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: add subscription detachment sample #152

Merged
merged 4 commits into from
Sep 14, 2020
Merged

samples: add subscription detachment sample #152

merged 4 commits into from
Sep 14, 2020

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Jul 10, 2020 •
edited
Loading

Add a sample for subscription detachment. The test can't be run yet because the feature is still being rolled out.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

The service is live, but we may want to hold off publishing this sample until the library has transitioned to using the microgenerator.

@anguillanneuf anguillanneuf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 10, 2020
pradn
pradn requested changes Jul 10, 2020
View reviewed changes
samples/snippets/iam.py Outdated Show resolved Hide resolved
samples/snippets/iam_test.py Outdated Show resolved Hide resolved
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@anguillanneuf anguillanneuf requested a review from pradn July 10, 2020 23:17
pradn
pradn requested changes Jul 11, 2020
View reviewed changes
samples/snippets/iam_test.py Show resolved Hide resolved
pradn
pradn approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tianzi!

samples/snippets/iam_test.py Show resolved Hide resolved
@anguillanneuf anguillanneuf mentioned this pull request Jul 15, 2020
Merged
3 tasks
@busunkim96 busunkim96 closed this Jul 31, 2020
@plamut plamut reopened this Jul 31, 2020
@anguillanneuf anguillanneuf mentioned this pull request Aug 6, 2020
Closed
@anguillanneuf anguillanneuf marked this pull request as ready for review September 1, 2020 19:13
@anguillanneuf anguillanneuf requested review from hongalex and a team as code owners September 1, 2020 19:13
@anguillanneuf anguillanneuf requested review from engelke and removed request for a team September 1, 2020 19:13
@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 14, 2020
@anguillanneuf anguillanneuf merged commit 0b53380 into master Sep 14, 2020
@anguillanneuf anguillanneuf deleted the detach branch June 4, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@hongalex hongalex Awaiting requested review from hongalex

@engelke engelke Awaiting requested review from engelke

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anguillanneuf @pradn @plamut @googlebot @busunkim96