samples: subscription detachment #289
Conversation
googlebot
added
the
cla: yes
hannahrogers-google
added
the
do not merge
anguillanneuf
removed
the
do not merge
| .addPaths("dead_letter_policy.dead_letter_topic") | ||
| // A default of 5 is applied upon successful update. | ||
| .addPaths("dead_letter_policy.max_delivery_attempts") | ||
| .addPaths("dead_letter_policy") |
There was a problem hiding this comment.
This, like it's predecessor looks wrong - shouldn't this be a constant defined in the library?
There was a problem hiding this comment.
Delivery attempt is not a constant defined in the library. In fact, it is best-effort only, and when no dead letter policy is attached, users won't be able to access delivery attempts.
There was a problem hiding this comment.
Understood - if it's understood as something important and understood as something special - it should be defined in the library in some way.
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=========================================
Coverage 79.21% 79.21%
Complexity 318 318
=========================================
Files 21 21
Lines 2892 2892
Branches 155 155
=========================================
Hits 2291 2291
Misses 536 536
Partials 65 65 Continue to review full report at Codecov.
|
Add Java sample for subscription detachment. The test can't be run yet because the feature is still being rolled out.
FYI: A DetachSubscriptionRequest is used instead of SubscriptionName.