add loop and timeout for properties queries on system tests #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrossi
approved these changes
Apr 10, 2019
tests/system/test_metadata.py
Outdated
| ), "Metadata was not updated in time." | ||
|
|
||
| time.sleep(1) | ||
|
|
||
| properties = get_properties_of_kind("AnyKind") |
There was a problem hiding this comment.
This line is redundant. You already have properties.
|
Actually, I see now that Kokoro has failed for the same thing on |
|
Yeah, I had seen that. I was not expecting a quick review ;) Will fix. |
|
Sorry, got over excited...
…On Tue, Apr 9, 2019, 10:56 PM Carlos de la Guardia ***@***.***> wrote:
Yeah, I had seen that. I was not expecting a quick review ;) Will fix.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJDK-z2B3Qr33Hi9Rb76F9ykQPWrkdKks5vfVLygaJpZM4cl6cn>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem locally for me.