Intermittent system test failure

[chrisrossi]

Intermittently, we get this system test failure:

___________________________________________ test_get_properties_of_kind ___________________________________________

dispose_of = <function dispose_of.<locals>.delete_entity at 0x7f0bb03d4510>

    @pytest.mark.usefixtures("client_context")
    def test_get_properties_of_kind(dispose_of):
        from google.cloud.ndb.metadata import get_properties_of_kind
    
        class AnyKind(ndb.Model):
            foo = ndb.IntegerProperty()
            bar = ndb.StringProperty()
            baz = ndb.IntegerProperty()
            qux = ndb.StringProperty()
    
        entity1 = AnyKind(foo=1, bar="x", baz=3, qux="y")
        entity1.put()
        dispose_of(entity1.key._key)
    
        properties = get_properties_of_kind("AnyKind")
>       assert properties == ["bar", "baz", "foo", "qux"]
E       AssertionError: assert [] == ['bar', 'baz', 'foo', 'qux']
E         Right contains more items, first extra item: 'bar'
E         Use -v to get the full diff

tests/system/test_metadata.py:220: AssertionError

I've only seen this happen on a Datastore backed data store, not on a Firestore backed data store. I suspect the issue is that it takes some amount of time for the metadata about "AnyKind" to get updated after the entity is saved. Maybe a retry loop would be in order.

[chrisrossi]

This is happening almost every time now in Kokoro.

[cguardia]

Fixed with PR #70.

[tseaver]

Seems to have raised its ugly head again.

[meredithslota]

@tseaver I'm going to close this based on some of the recent fixes, assuming you haven't seen this again. Please let us know if you see it again.

[tseaver]

@meredithslota Seems good. PR #726 noted explicitly that it was fixing this bug, but the , might have defeated the autoclose.