Store Structured Properties in backwards compatible way #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chrisrossi
force-pushed
the
legacy-structured-props
branch
from
59e3841 to
f316a37
Compare
cguardia
approved these changes
Sep 4, 2019
google/cloud/ndb/model.py
Outdated
| @@ -3861,6 +3899,48 @@ def _get_value_size(self, entity): | |||
| values = [values] | |||
| return len(values) | |||
|
|
|||
| def _to_datastore(self, entity, data, prefix="", repeated=False): | |||
| """Override of :method:`StructuredProperty._to_datastore`. | |||
There was a problem hiding this comment.
Rather, an override of Property._to_datastore, no?
added 2 commits
September 4, 2019 11:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NDB rewrite, when storing values for structured properties, has been taking advantage of the native Datastore capability to arbitrarily nest entities as property values. Data written using the new NDB, however, would not be compatible with the legacy (Python 2) version, which always only stores a single entity in Datastore, using dotted property names to store the values of structured properties.
This patch introduces a new context flag,
legacy_data, which, whenTrue, causes NDB to store data in such a way as to be backwards compatible with the old version. The flag isTrueby default, requiring users to make a conscious decision to break backwards compatibility.Fixes #178