StructuredProperty promotions expected to find properties separated by periods at a depth of 1; received ['promotions']

[chmoder]

Hi, this issue is related to the very well documented #122.

This error happened when trying to access the entity using appengine27 after saving it with appengine37.

My question is, should we consider the entities to be not backward compatible with the old NDB library after using this one?

Steps to reproduce

1. use python-ndb to update an entity on appengine37 with a property like: promotions = ndb.StructuredProperty(Promotion, repeated=True)
2. try to read this entity using the appengine27 ndb library.

Stack trace

StructuredProperty promotions expected to find properties separated by periods at a depth of 1; received ['promotions'] (/base/data/home/apps/p~csgapi-qa/qa.420639802264340764/base.py:219)
Traceback (most recent call last):
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 570, in dispatch
    return method(*args, **kwargs)
  File "/base/data/home/apps/p~csgapi-qa/qa.420639802264340764/auth.py", line 381, in post
    use_memcache=False
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/query.py", line 1253, in get
    return self.get_async(**q_options).get_result()
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/tasklets.py", line 383, in get_result
    self.check_success()
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/tasklets.py", line 427, in _help_tasklet_along
    value = gen.throw(exc.__class__, exc, tb)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/query.py", line 1266, in _get_async
    res = yield self.fetch_async(1, **q_options)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/tasklets.py", line 427, in _help_tasklet_along
    value = gen.throw(exc.__class__, exc, tb)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/query.py", line 995, in _run_to_list
    batch = yield rpc
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/tasklets.py", line 513, in _on_rpc_completion
    result = rpc.get_result()
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/api/apiproxy_stub_map.py", line 615, in get_result
    return self.__get_result_hook(self)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/datastore/datastore_query.py", line 2951, in __query_result_hook
    self.__results = self._process_results(query_result.result_list())
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/datastore/datastore_query.py", line 2984, in _process_results
    for result in results]
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/datastore/datastore_rpc.py", line 194, in pb_to_query_result
    return self.pb_to_entity(pb)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/model.py", line 691, in pb_to_entity
    entity = modelclass._from_pb(pb, key=key, set_key=False)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/model.py", line 3216, in _from_pb
    _property_map[property_map_key]._deserialize(ent, p)
  File "/base/alloc/tmpfs/dynamic_runtimes/python27g/941d77da994078b1/python27/python27_lib/versions/1/google/appengine/ext/ndb/model.py", line 2439, in _deserialize
    (self._name, depth, parts))
RuntimeError: StructuredProperty promotions expected to find properties separated by periods at a depth of 1; received ['promotions']

[chrisrossi]

I'll work on updating how we store StructuredProperties to be backwards compatible.

[chmoder]

I just wanted to let you know we got some time this week to test the update and it appears to serialize the repeated StructuredProperty back to period separated properties.

Thank you!

[andrewsg]

Great! Thank you for this feedback.

…

On Fri, Sep 6, 2019, 10:11 AM Thomas Cross ***@***.***> wrote: I just wanted to let you know we got some time this week to test the update and it appears to serialize the repeated StructuredProperty back to period separated properties. Thank you! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#178?email_source=notifications&email_token=AAFHTV6OC3EMJB7LTHN6FG3QIKFMBA5CNFSM4IRQGR5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DO37A#issuecomment-528936444>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFHTV5QAC6IMS6DRYHYR53QIKFMBANCNFSM4IRQGR5A> .