-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split pandas system tests to new module #548
refactor: split pandas system tests to new module #548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the system tests are getting some structure. 👍 I think it's good, but I did spot an incorrectly converted assertion.
BTW, in the future, I suggest keeping related changes in their own commits, as it makes it easier to glance over the diff and directly see the key differences. That assertion conversion could have been easily overlooked.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Follow-up to #448
Towards #366