refactor: split system tests across modules #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it easier to see which pandas tests we have and which we are missing.
tswast
requested review from
a team and
stephaniewang526
and removed request for
a team
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tswast
added
the
do not merge
|
To make this easier to review, I think I'll do this in multiple PRs. I don't want to accidentally miss a test. |
|
#475 should be merged before this. I'll probably split the "moves" into separate PRs as well (dbapi first, then pandas/arrow) |
I'll go with multiple PRs. (One for pandas and one for DB-API). I fear if I try to resolve merge conflicts, I'll accidentally delete some tests. |
4 tasks
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 15, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Follow-up to #448 Towards #366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to see which pandas tests
we have and which we are missing.
Despite the branch name, not exactly related to #56, but I realized I was having trouble determining if this pandas DATETIME use case was tested when all system tests were in the same file.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #366