Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docstring returns section #937

Merged
merged 21 commits into from
Sep 5, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Aug 28, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 28, 2024
@arwas11 arwas11 requested a review from tswast August 28, 2024 21:45
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

bigframes/_config/__init__.py Outdated Show resolved Hide resolved
bigframes/_config/__init__.py Outdated Show resolved Hide resolved
bigframes/_config/__init__.py Outdated Show resolved Hide resolved
tswast and others added 12 commits September 3, 2024 15:39
* fix: unordered errors in ml train_test_split

* fix tests
* chore: add tpch q4-8

* remove 10t test
* deps: Update mininum support to Pandas 1.5.3 and Pyarrow 10.0.1

* fixing tests
* test: add CSV sample data file for testing
* perf: Improve repr performance

* extract gbq metadata from nodes to common struct

* clarify fast head

* fix physical_schema to be bq client types

* add classmethod annotation to GbqTable struct factory method

* add classmethod annotation to GbqTable struct factory method

---------

Co-authored-by: Tim Sweña (Swast) <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Sep 3, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Sep 4, 2024
@arwas11 arwas11 assigned arwas11 and unassigned arwas11 Sep 4, 2024
@arwas11 arwas11 marked this pull request as ready for review September 5, 2024 16:21
@arwas11 arwas11 requested review from a team as code owners September 5, 2024 16:21
@arwas11 arwas11 requested a review from GarrettWu September 5, 2024 16:21
@tswast tswast enabled auto-merge (squash) September 5, 2024 21:37
@tswast tswast merged commit a2640a2 into main Sep 5, 2024
19 of 23 checks passed
@tswast tswast deleted the b296390934-docstrings-type-annotation branch September 5, 2024 23:41
tswast added a commit that referenced this pull request Oct 3, 2024
* docs: add docstring return type section to BigQueryOptions class

* docs: add docstring return type section to BigQueryOptions class

* docs: add docstrings to SamplingOptions class

* feat: add Gemini 1.5 stable models support (#945)

* feat: add Gemini 1.5 stable models support

* add to loader

* refactor: Simplify projection nodes (#961)

* docs: add docstring returns section to Options (#937)

* chore: drop unused columns at is_monotonic methods (#912)

* chore: drop unused columns at is_monotonic methods

* fixing mypy

* test: retry streaming tests to accommodate flakiness (#956)

* test: retry streaming tests to accommodate flakiness

* reduce delay, increase retries

* fix: make `read_gbq_function` work for multi-param functions (#947)

* fix: make `read_gbq_function` work for multi-param functions

* fix hyperlink

* specify hyperlink differently

* make hyperlink markdown format

* fix: support `read_gbq_function` for axis=1 application (#950)

* fix: support `read_gbq_function` for axis=1 application

* remove stray newline

* Update bigframes/session/__init__.py

* remove first person reference in the doc

* use correct product name

---------

Co-authored-by: Tim Sweña (Swast) <[email protected]>

* docs: update title of pypi notebook example to reflect use of the PyPI public dataset (#952)

In response to feedback on internal change 662899733.

* docs: add docstrings to SamplingOptions class

---------

Co-authored-by: Garrett Wu <[email protected]>
Co-authored-by: TrevorBergeron <[email protected]>
Co-authored-by: Chelsea Lin <[email protected]>
Co-authored-by: Shobhit Singh <[email protected]>
Co-authored-by: Tim Sweña (Swast) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants