Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tpch q4-8 #926

Merged
merged 7 commits into from
Aug 29, 2024
Merged

chore: add tpch q4-8 #926

merged 7 commits into from
Aug 29, 2024

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Aug 23, 2024

Also removed 10T in config for now, too slow.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 23, 2024
@Genesis929 Genesis929 marked this pull request as ready for review August 23, 2024 23:19
@Genesis929 Genesis929 requested review from a team as code owners August 23, 2024 23:19
@Genesis929 Genesis929 requested a review from tswast August 23, 2024 23:19
@Genesis929 Genesis929 requested a review from chelsea-lin August 23, 2024 23:19
@@ -6,5 +6,3 @@
{"benchmark_suffix": "100g_unordered", "dataset_id": "tpch_0100g", "ordered": false}
{"benchmark_suffix": "1t_ordered", "dataset_id": "tpch_0001t", "ordered": true}
{"benchmark_suffix": "1t_unordered", "dataset_id": "tpch_0001t", "ordered": false}
{"benchmark_suffix": "10t_ordered", "dataset_id": "tpch_0010t", "ordered": true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these extensive data benchmarks being intentionally removed?

Copy link
Collaborator Author

@Genesis929 Genesis929 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still thinking about this, for now I want to remove this.

@Genesis929 Genesis929 merged commit 2f6cd9f into main Aug 29, 2024
21 of 23 checks passed
@Genesis929 Genesis929 deleted the bench-upd5 branch August 29, 2024 17:31
arwas11 pushed a commit that referenced this pull request Sep 3, 2024
* chore: add tpch q4-8

* remove 10t test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants