Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable BYOSA test for remote_function cloud function #432

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 13, 2024

This support was added in PR#407 but the test was only verified locally since the project bigframes-load-testing is latchkey managed and would require some extra configuration to set-up. This change does one step better by enabling the test in the automated pipelines by targeting it to a different project bigframes-dev-perf which is easier to set up through cloud console. Eventually it should be moved to run entirely in bigframes-load-testing after the necessary configuration is done through latchkey (created internal issue 329339908 to track the work).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners March 13, 2024 02:41
@shobsi shobsi requested a review from tswast March 13, 2024 02:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 13, 2024
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 40ddb69 into main Mar 15, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-gcf-sa-test branch March 15, 2024 18:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants