Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support BYOSA in remote_function #407

Merged
merged 7 commits into from
Mar 5, 2024
Merged

feat: Support BYOSA in remote_function #407

merged 7 commits into from
Mar 5, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 5, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 328138730 🦕

@shobsi shobsi requested review from a team as code owners March 5, 2024 01:24
@shobsi shobsi requested a review from Genesis929 March 5, 2024 01:24
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 5, 2024
@Genesis929 Genesis929 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit d92ced2 into main Mar 5, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-gcf-sa branch March 5, 2024 20:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2024
@release-please release-please bot mentioned this pull request Mar 5, 2024
Merged
@shobsi shobsi mentioned this pull request Mar 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Genesis929 Genesis929 Genesis929 approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @Genesis929