Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: re-arrange describe() logic into two helper methods #1005

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Sep 20, 2024

It feels like an overkill to introduce class-level constants.

@sycai sycai requested review from a team as code owners September 20, 2024 18:06
@sycai sycai requested a review from tswast September 20, 2024 18:06
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 20, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 20, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

@sycai sycai merged commit 5c1a4c7 into main Sep 24, 2024
22 of 23 checks passed
@sycai sycai deleted the sycai-refactor-describe branch September 24, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants