-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript): correctly import long #541
Conversation
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 16 16
Lines 965 965
Branches 86 86
=======================================
Hits 915 915
Misses 42 42
Partials 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably use mkdirp
for the directory creation, so that we work on Windows (and other platforms without mkdir
).
Otherwise, this looks good to me; up to you whether you add mkdirp
in another pull request (I probably would).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you \o/
Fixes #526