Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subscription): promisify Subscription#close #282

Merged
merged 2 commits into from
Oct 10, 2018
Merged

fix(subscription): promisify Subscription#close #282

merged 2 commits into from
Oct 10, 2018

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Oct 10, 2018 •
edited
Loading

Fixes #212
Closes #223

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested a review from a team October 10, 2018 15:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2018
@ghost ghost assigned callmehiphop Oct 10, 2018
@ghost ghost assigned JustinBeckwith Oct 10, 2018
@JustinBeckwith JustinBeckwith merged commit 4d51686 into googleapis:master Oct 10, 2018
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@dpebot @JustinBeckwith
chore: make the CircleCI config consistent (googleapis#282)
a4b1b61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees

@JustinBeckwith JustinBeckwith

@callmehiphop callmehiphop

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callmehiphop @JustinBeckwith @googlebot