-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(subscriber): return a promise on close #223
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
* 'master' of github.com:scragg0x/nodejs-pubsub: chore(subscriber): linting fix(subscriber): return a promise on close
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 100% 99.87% -0.13%
==========================================
Files 10 10
Lines 807 816 +9
==========================================
+ Hits 807 815 +8
- Misses 0 1 +1
Continue to review full report at Codecov.
|
CLAs look good, thanks! |
Sorry for the extra commits, probably want to squash if you merge. |
@callmehiphop can you take a look at this? |
@scragg0x sorry I kind of dropped the ball here, we actually have a handy util for promisifying our methods. If you want to take a crack at getting that working here, that would be amazing! Otherwise I can totally tackle this |
@callmehiphop You can go ahead and take this. I didn't use the promisify lib since |
* Updating the Readme: Node is now beta * Updating the README stage badge * Updating releaes_quality in .cloud-repo-tools.json
Fixes #212
Not sure if this is the best way to fix, but here you go!