Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriber): return a promise on close #223

Closed
wants to merge 9 commits into from
Closed

fix(subscriber): return a promise on close #223

wants to merge 9 commits into from

Conversation

scragg0x
Copy link

Fixes #212

Not sure if this is the best way to fix, but here you go!

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 27, 2018
Matthew Scragg added 4 commits August 28, 2018 10:32
* 'master' of github.com:scragg0x/nodejs-pubsub:
  chore(subscriber): linting
  fix(subscriber): return a promise on close
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #223 into master will decrease coverage by 0.12%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage     100%   99.87%   -0.13%     
==========================================
  Files          10       10              
  Lines         807      816       +9     
==========================================
+ Hits          807      815       +8     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/subscriber.js 99.37% <90.9%> (-0.63%) ⬇️
src/connection-pool.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8667a...7beec08. Read the comment docs.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 28, 2018
@scragg0x
Copy link
Author

Sorry for the extra commits, probably want to squash if you merge.

@ghost ghost assigned JustinBeckwith Aug 30, 2018
@JustinBeckwith
Copy link
Contributor

@callmehiphop can you take a look at this?

@ghost ghost assigned callmehiphop Oct 4, 2018
@callmehiphop
Copy link
Contributor

callmehiphop commented Oct 4, 2018

@scragg0x sorry I kind of dropped the ball here, we actually have a handy util for promisifying our methods. If you want to take a crack at getting that working here, that would be amazing! Otherwise I can totally tackle this

@scragg0x
Copy link
Author

scragg0x commented Oct 4, 2018

@callmehiphop You can go ahead and take this. I didn't use the promisify lib since close calls 2 other async functions, one callback style and the other promise.

feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* Updating the Readme: Node is now beta

* Updating the README stage badge

* Updating releaes_quality in .cloud-repo-tools.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriber/Subscription.close does not support promises
4 participants