Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxBytes batching sending empty messages #281

Conversation

Legogris
Copy link
Contributor

@Legogris Legogris commented Oct 4, 2018

Fixes #279 and #280.
Regression test added.
Please let me know if you prefer me to split this up in separate PRs.

  • Tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated (not necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 4, 2018
@JustinBeckwith
Copy link
Contributor

Thanks for the PR @Legogris! If you can go through the CLA signing thingy, we'll take a look!

@Legogris
Copy link
Contributor Author

Legogris commented Oct 4, 2018

I signed it!

Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

@callmehiphop callmehiphop added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 10, 2018
@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@callmehiphop
Copy link
Contributor

@JustinBeckwith looks like merging is blocked because of the CLA, are there any other steps we need to take?

@JustinBeckwith JustinBeckwith added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants