Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher not pushing immediately when single message is larger than maxBytes #279

Closed
Legogris opened this issue Oct 4, 2018 · 0 comments
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Legogris
Copy link
Contributor

Legogris commented Oct 4, 2018

Publisher immediately publishes a message that is exactly equal to maxBytes. Is there any particular reason why this is only done when there is an exact match (and then queued for sending later any way) rather than when it's bigger or equal?

I have a PR ready for this.

Environment details

  • OS: NixOS / ubuntu
  • Node.js version: v8.11.3
  • npm version: 5.6.0
  • @google-cloud/pubsub version: 0.20.1

Expected behavior

  1. Post single message larger than maxBytes
  2. Message gets published immediately

Actual behavior

  1. Publish single message larger than maxBytes
  2. Message is queued
@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 4, 2018
@ghost ghost removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Oct 10, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
* add getReplicationStates in table

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants