samples: add schema samples, typescript sample support #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication of added methods
…O sample test working
product-auto-label
bot
added
api: pubsub
|
Here is the summary of changes. You are about to add 20 region tags.
This comment is generated by snippet-bot.
|
google-cla
bot
added
the
cla: yes
anguillanneuf
suggested changes
Apr 16, 2021
…ma-support # Conflicts: # src/pubsub.ts # test/pubsub.ts
feywind
changed the title
anguillanneuf
suggested changes
Jun 3, 2021
anguillanneuf
approved these changes
Jun 4, 2021
samples: add more system-tests for schema samples
…ises' object instead of 'fs/promises'
feywind
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
Source-Link: googleapis/synthtool@3602660 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e6d785d6de3cab027f6213d95ccedab4cab3811b0d3172b78db2216faa182e32 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1220
The remainder of this PR is about adding schema sample snippets, as well as some preliminary TypeScript snippet support. There are still some linting issues with the generated samples, and I wanted to talk about the method used here before committing to it, so it's still marked as a work in progress.