Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Pub/Sub server schema to the Node client library #1220

Closed
feywind opened this issue Mar 2, 2021 · 3 comments · Fixed by #1262
Closed

Add support for Pub/Sub server schema to the Node client library #1220

feywind opened this issue Mar 2, 2021 · 3 comments · Fixed by #1262
Assignees
@feywind
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@feywind
Copy link
Collaborator

feywind commented Mar 2, 2021

This feature is currently in preview, and we need to get support for it in the library. Some things that need to be included (may expand):

  • Support in the GAPIC layer (done)
  • Support in the veneer (PubSub class) layer
  • Added tests
  • Added system-tests
  • Added samples
  • Added samples system-tests
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Mar 2, 2021
@feywind feywind self-assigned this Mar 2, 2021
@feywind
Copy link
Collaborator Author

feywind commented Mar 2, 2021

It's looking like the PR for this will also address this issue, finally: #1091

@gavingolden
Copy link

Is there an ETA on this?

@feywind
Copy link
Collaborator Author

feywind commented Apr 6, 2021 •
edited
Loading

@gavingolden It's mostly "asap" at this point, but I can't give a specific date. I think the server side support is already turned on, on a preview basis, but client library support is still variable. Theoretically you should be able to do the basic schema operations using gcloud or the GCP web site, but I don't know a lot of the bigger project management picture.

Edit: I should probably tag in @kamalaboulhosn

@feywind feywind mentioned this issue Apr 16, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 7, 2021
@feywind
samples: add schema samples, typescript sample support (#1262)
f9dc4c6 
fixes: #1220

The remainder of this PR is about adding schema sample snippets, as well as some preliminary TypeScript snippet support. There are still some linting issues with the generated samples, and I wanted to talk about the method used here before committing to it, so it's still marked as a work in progress.
@feywind feywind mentioned this issue Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feywind feywind

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples: add schema samples, typescript sample support feywind/nodejs-pubsub
2 participants
@gavingolden @feywind