tests: fix zalgo flakiness in seek tests, and convert them to async/promises to make the logic more rigorous #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romises to make the logic more rigorous
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 25 25
Lines 11066 11066
Branches 595 546 -49
=======================================
Hits 10821 10821
Misses 241 241
Partials 4 4 Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Sep 23, 2020
product-auto-label
bot
added
the
api: pubsub
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 9, 2021
VERSION is used in @google-cloud/cloud-rad to publish ref docs for a particular version. Pass VERSION in via Stubby or Fusion. Source-Link: googleapis/synthtool@740366b Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:bbdd52de226c00df3356cdf25460397b429ab49552becca645adbc412f6a4ed5
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
VERSION is used in @google-cloud/cloud-rad to publish ref docs for a particular version. Pass VERSION in via Stubby or Fusion. Source-Link: googleapis/synthtool@740366b Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:bbdd52de226c00df3356cdf25460397b429ab49552becca645adbc412f6a4ed5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1105
Fixes: #1106
I guess in the long run, it's debatable if the async/Promise changes made it more readable, but I think it did uncover some more potentially flaky behaviors that hadn't bitten us yet.