Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.3.0 #507

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 16, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.codehaus.mojo:flatten-maven-plugin (source) 1.2.7 -> 1.3.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

BEGIN_COMMIT_OVERRIDE
deps: update dependency org.codehaus.mojo:flatten-maven-plugin to v1.3.0

This resolves the problem of test-scope dependencies unexpectedly excluded.
END_COMMIT_OVERRIDE

@renovate-bot renovate-bot requested a review from a team as a code owner August 16, 2022 22:22
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@alicejli alicejli added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from c5ade45 to 49c7f7a Compare August 17, 2022 15:34
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2022
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2022
@alicejli alicejli added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from 49c7f7a to 0d5ab0e Compare August 19, 2022 18:33
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2022
@suztomo
Copy link
Member

suztomo commented Oct 21, 2022

@meltsufin I wrote the analysis that the validation result is false positive #507 (comment) . The flatten plugin new version is working correctly. The validation logic is wrong.

@meltsufin
Copy link
Member

@meltsufin I wrote the analysis that the validation result is false positive #507 (comment) . The flatten plugin new version is working correctly. The validation logic is wrong.

Can you create an issue for this? Would you be able to provide a fix so that we can upgrade the plugin?

@suztomo
Copy link
Member

suztomo commented Oct 21, 2022

Issue #525

The fix in the dependencies.sh (templated in OwlBot post processor): https://github.com/googleapis/synthtool/pull/1663/files

@suztomo
Copy link
Member

suztomo commented Oct 24, 2022

This should become green after googleapis/java-storage#1732 is merged to the main branch and we retry the "downstream / dependencies (11, java-storage)" check.

@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Oct 24, 2022
@suztomo
Copy link
Member

suztomo commented Oct 24, 2022

I'm rebasing this pull request to see flatten plugin check.

@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from 8c78152 to 63cc831 Compare October 24, 2022 17:02
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022
@suztomo
Copy link
Member

suztomo commented Oct 24, 2022

Good. It failed.

+ diff /home/runner/work/java-shared-config/java-shared-config/.kokoro/java-storage-v2.9.3-expected-flattened-dependencies.txt .actual-flattened-dependencies-list.txt
Diff from the expected file (java-storage-v2.9.3-expected-flattened-dependencies.txt):
15a16
> com.google.errorprone:error_prone_annotations:jar:2.14.0:compile

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2022
@suztomo suztomo merged commit ce1a04e into googleapis:main Oct 24, 2022
@suztomo suztomo added the release-please:force-run To run release-please label Nov 18, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 18, 2022
@suztomo suztomo added the release-please:force-run To run release-please label Nov 18, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants