Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better validation for flatten-maven-plugin #525

Closed
suztomo opened this issue Oct 19, 2022 · 5 comments · Fixed by #530
Closed

Better validation for flatten-maven-plugin #525

suztomo opened this issue Oct 19, 2022 · 5 comments · Fixed by #530
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Oct 19, 2022

#507 is failing with the downstream java-storage test.

This is the fix I recently made mojohaus/flatten-maven-plugin#185 to the flatten-maven-plugin. The treatment of test-scope dependencies were incorrect.

We need to adjust the validation in dependencies.sh for the fixed behavior.
@meltsufin meltsufin changed the title Better validation for flatte-maven-plugin Better validation for flatten-maven-plugin Oct 19, 2022
@meltsufin
Copy link
Member

Why does the validation need to be adjusted if the fix is in?

@suztomo
Copy link
Member Author

suztomo commented Oct 19, 2022

Because the validation was relying on the previous incorrect behavior of flatten-maven-plugin.

(What's the incorrect behavior? mojohaus/flatten-maven-plugin#185 has diagram to explain the dependency in test-scope.)

@diegomarquezp diegomarquezp added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 20, 2022
This was referenced Oct 21, 2022
Merged
Merged
@suztomo
Copy link
Member Author

suztomo commented Oct 24, 2022 •
edited
Loading

https://github.com/googleapis/synthtool/pull/1663/files is 1st step to remove the check in each repository. The check to confirm the behavior of flatten-maven-plugin should happen in this java-shared-config repository, rather than every individual library repository.

@suztomo suztomo mentioned this issue Oct 24, 2022
Merged
suztomo added a commit that referenced this issue Oct 24, 2022
@suztomo
ci: adding flatten plugin check (#530)
92fcecc 
Fixes #525
@suztomo
Copy link
Member Author

suztomo commented Oct 24, 2022 •
edited
Loading

Reopening this as java-storage has not received the OwlBot template change in googleapis/synthtool#1663

@suztomo suztomo reopened this Oct 24, 2022
@diegomarquezp
Copy link
Contributor

Closing as java-storage got the template change merged in googleapis/java-storage#1732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: adding flatten plugin check suztomo/java-shared-config
3 participants
@suztomo @meltsufin @diegomarquezp