Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

deps: revert protobuf to 3.19 and common-protos 2.8.3 #798

Merged
merged 2 commits into from
Apr 12, 2022
Merged

deps: revert protobuf to 3.19 and common-protos 2.8.3 #798

merged 2 commits into from
Apr 12, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Apr 12, 2022

This reverts commit 19202bc.

@suztomo suztomo requested a review from a team as a code owner April 12, 2022 15:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 12, 2022
@suztomo suztomo requested a review from Neenu1995 April 12, 2022 15:56
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2022
@suztomo
Copy link
Member Author

suztomo commented Apr 12, 2022 •
edited
Loading

This needs to wait for google-common-protos (just released). mvn -B dependency:analyze -DfailOnWarning=true failed:

+-com.google.cloud:google-cloud-core:2.5.12-SNAPSHOT
  +-com.google.protobuf:protobuf-java:3.19.4
and
+-com.google.cloud:google-cloud-core:2.5.12-SNAPSHOT
  +-com.google.protobuf:protobuf-java-util:3.19.4
    +-com.google.protobuf:protobuf-java:3.19.4 (managed) <-- com.google.protobuf:protobuf-java:3.20.0
and
+-com.google.cloud:google-cloud-core:2.5.12-SNAPSHOT
  +-com.google.api.grpc:proto-google-common-protos:2.8.2
    +-com.google.protobuf:protobuf-java:3.19.4 (managed) <-- com.google.protobuf:protobuf-java:3.20.0
and
+-com.google.cloud:google-cloud-core:2.5.12-SNAPSHOT
  +-com.google.api.grpc:proto-google-iam-v1:1.3.0
    +-com.google.protobuf:protobuf-java:3.19.4 (managed) <-- com.google.protobuf:protobuf-java:3.20.0
]

https://search.maven.org/artifact/com.google.api.grpc/proto-google-iam-v1/1.3.0/jar has

  <dependencies>
    <dependency>
      <groupId>com.google.protobuf</groupId>
      <artifactId>protobuf-java</artifactId>
      <version>3.19.4</version>
      <scope>compile</scope>

So google-iam is fine.

@suztomo suztomo changed the title deps: revert protobuf to 3.19 deps: revert protobuf to 3.19 and common-protos 2.8.3 Apr 12, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0f36a84 into googleapis:main Apr 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2022
@suztomo suztomo deleted the revert_protobuf branch April 12, 2022 17:22
@release-please release-please bot mentioned this pull request Apr 12, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 14, 2022
@release-please
chore(main): release 2.6.0 (#786)
95b1e0c 
🤖 I have created a release *beep* *boop*
---


## [2.6.0](v2.5.11...v2.6.0) (2022-04-14)


### Features

* **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](#793)) ([2880112](2880112))
* **java:** remove Netty Native Image configuration after relocation to gax ([#771](#771)) ([9ba04f9](9ba04f9))
* **java:** remove protobuf Native Image configuration ([#784](#784)) ([0bc8549](0bc8549))
* remove native-image.properties settings  after relocation ([#794](#794)) ([e24bfdd](e24bfdd))
* remove resource-config after relocation ([#795](#795)) ([87e2973](87e2973))
* remove substitutions after relocation to gax ([#789](#789)) ([29291e9](29291e9))


### Bug Fixes

* **java:** register test class for reflection to fix native image test ([#766](#766)) ([6fe52c3](6fe52c3))


### Dependencies

* revert protobuf to 3.19 and common-protos 2.8.3 ([#798](#798)) ([0f36a84](0f36a84))
* update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](#800)) ([8430aee](8430aee))
* update dependency com.google.api:gax-bom to v2.16.0 ([#785](#785)) ([fd435b0](fd435b0))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](#792)) ([4d201ac](4d201ac))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](#796)) ([dc28a0f](dc28a0f))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](#783)) ([4ed5ba4](4ed5ba4))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](#799)) ([fce5315](fce5315))
* update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](#788)) ([4e71f68](4e71f68))
* update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](#791)) ([fe006c6](fe006c6))
* update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](#797)) ([570f8d5](570f8d5))
* update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](#787)) ([19202bc](19202bc))
* update dependency io.grpc:grpc-bom to v1.45.1 ([#780](#780)) ([6e3bf35](6e3bf35))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit to googleapis/google-cloud-java that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 2.6.0 (#786)
473b790 
🤖 I have created a release *beep* *boop*
---


## [2.6.0](googleapis/java-core@v2.5.11...v2.6.0) (2022-04-14)


### Features

* **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](googleapis/java-core#793)) ([cafd489](googleapis/java-core@cafd489))
* **java:** remove Netty Native Image configuration after relocation to gax ([#771](googleapis/java-core#771)) ([9cc7dba](googleapis/java-core@9cc7dba))
* **java:** remove protobuf Native Image configuration ([#784](googleapis/java-core#784)) ([7a8df66](googleapis/java-core@7a8df66))
* remove native-image.properties settings  after relocation ([#794](googleapis/java-core#794)) ([219a519](googleapis/java-core@219a519))
* remove resource-config after relocation ([#795](googleapis/java-core#795)) ([8ed3110](googleapis/java-core@8ed3110))
* remove substitutions after relocation to gax ([#789](googleapis/java-core#789)) ([85280b1](googleapis/java-core@85280b1))


### Bug Fixes

* **java:** register test class for reflection to fix native image test ([#766](googleapis/java-core#766)) ([fa07125](googleapis/java-core@fa07125))


### Dependencies

* revert protobuf to 3.19 and common-protos 2.8.3 ([#798](googleapis/java-core#798)) ([27ca70c](googleapis/java-core@27ca70c))
* update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](googleapis/java-core#800)) ([3abc47d](googleapis/java-core@3abc47d))
* update dependency com.google.api:gax-bom to v2.16.0 ([#785](googleapis/java-core#785)) ([bd33a76](googleapis/java-core@bd33a76))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](googleapis/java-core#792)) ([3f85e62](googleapis/java-core@3f85e62))
* update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](googleapis/java-core#796)) ([d6ea18e](googleapis/java-core@d6ea18e))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](googleapis/java-core#783)) ([48594f3](googleapis/java-core@48594f3))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](googleapis/java-core#799)) ([9fe7d35](googleapis/java-core@9fe7d35))
* update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](googleapis/java-core#788)) ([cfdabb4](googleapis/java-core@cfdabb4))
* update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](googleapis/java-core#791)) ([d9ff405](googleapis/java-core@d9ff405))
* update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](googleapis/java-core#797)) ([dfc3c57](googleapis/java-core@dfc3c57))
* update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](googleapis/java-core#787)) ([51f59fc](googleapis/java-core@51f59fc))
* update dependency io.grpc:grpc-bom to v1.45.1 ([#780](googleapis/java-core#780)) ([cd8a078](googleapis/java-core@cd8a078))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @Neenu1995