-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImageInfo, ImageId and test classes #794
Conversation
return this; | ||
} | ||
|
||
public Builder<T> status(Status status) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Question about the deprecation status: the dates a user inputs in those fields don't cause any behavioral changes on the server, do they? If a user passes in valid dates in the proper format, does the service move the deprecation status automatically for the user from Would the following proposal work?
|
@Test | ||
public void testToBuilder() { | ||
compareDiskImageConfiguration(CONFIGURATION, CONFIGURATION.toBuilder().build()); | ||
DiskId newDisk = DiskId.of("newProjet", "newZone", "newDisk"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Dates have no impact on the service. I think that what you suggest makes sense. I would also add a getter for each timestamp that returns the long timestamp: public String deprecated();
public Long deprecatedTimestamp(); I agree that setters should only take long. I also think that getters for |
If I understand the issue correctly the timestamp in this case is merely a label (open text supplied by the user) with a recommended convention for the value. If so, honestly I am not sure why the service API even bothered with proving a specific setting for it (as oppose to providing a way to specify any set of attributes) and in this case would not bother in trying |
* {@code gs://bucket/file}). | ||
*/ | ||
public Builder source(String source) { | ||
this.source = source; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Done with my pass. |
Yes but I don't think this was intended but rather a missing check on the service's side. If you look at the docs for image.deprecate it seems to me that the RFC format is not intended to be just a suggestion. |
I fixed all comments but the ones on |
/** | ||
* Returns a builder for the {@code DeprecationStatus} object. | ||
*/ | ||
public Builder<T> toBuilder() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I add String setters/getters to |
Looks good. I think there few comments we need to address before we can merge. |
Comments should be fixed now (but the one concerning
|
@@ -393,7 +393,7 @@ Image toPb() { | |||
/** | |||
* Returns a builder for an {@code ImageInfo} object given the image identity and an image | |||
* configuration. Use {@link DiskImageConfiguration} to create an image from an existing disk. Use | |||
* {@link RawImageConfiguration} to create an image from a raw image stored in Google Cloud | |||
* {@link StorageImageConfiguration} to create an image from a raw image stored in Google Cloud |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Looks good! Few javadoc related fixes (IlegalArgumentException) and question/suggestions. |
- Add public builder and factory methods to DeprecationStatus - Add setters/getters for DeprecationStatus timestamps as String - Add ImageId, configuration classes and ImageInfo class
assertEquals("delete", deprecationStatus.deleted()); | ||
try { | ||
deprecationStatus.deletedMillis(); | ||
fail("Expected IllegalArgumentException"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…to v2.5.2 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-kms-bom](https://togithub.com/googleapis/java-kms) | `2.5.1` -> `2.5.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/compatibility-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/confidence-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-kms).
…is#794) * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: fix deps Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu1995 <[email protected]>
…oogleapis#794) * fix!: remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae2c052743706161ac95adc5048ad5a3de8a6585 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWUyYzA1Mjc0MzcwNjE2MWFjOTVhZGM1MDQ4YWQ1YTNkZThhNjU4NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pom.xml * fix: update gapic-generator-java with mock service generation fixes PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu Shaji <[email protected]>
Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.
🤖 I have created a release *beep* *boop* --- ## [1.5.0](googleapis/java-resourcemanager@v1.4.0...v1.5.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#794](googleapis/java-resourcemanager#794)) ([d732072](googleapis/java-resourcemanager@d732072)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#796](googleapis/java-resourcemanager#796)) ([9f2a86e](googleapis/java-resourcemanager@9f2a86e)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#793](googleapis/java-resourcemanager#793)) ([edfaad3](googleapis/java-resourcemanager@edfaad3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.4.0](googleapis/java-talent@v2.3.0...v2.4.0) (2022-07-01) ### Features * Add a new operator on companyDisplayNames filter to further support fuzzy match by treating input value as a multi word token ([googleapis#788](googleapis/java-talent#788)) ([1460184](googleapis/java-talent@1460184)) * Add a new option TELECOMMUTE_JOBS_EXCLUDED under enum TelecommutePreference to completely filter out the telecommute jobs in response ([1460184](googleapis/java-talent@1460184)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#794](googleapis/java-talent#794)) ([d2e17f0](googleapis/java-talent@d2e17f0)) ### Documentation * Deprecate option TELECOMMUTE_EXCLUDED under enum TelecommutePreference ([1460184](googleapis/java-talent@1460184)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#797](googleapis/java-talent#797)) ([3e61e7f](googleapis/java-talent@3e61e7f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…r to v2.3.2 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-scheduler](https://togithub.com/googleapis/java-scheduler) | `2.3.0` -> `2.3.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/compatibility-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/confidence-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-scheduler). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
…onfig to v1.5.3 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.1` -> `1.5.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/compatibility-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/confidence-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​153-httpsgithubcomgoogleapisjava-shared-configcomparev152v153-2022-07-27) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.2...v1.5.3) ##### Dependencies - update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#​497](https://togithub.com/googleapis/java-shared-config/issues/497)) ([1fc6ab4](https://togithub.com/googleapis/java-shared-config/commit/1fc6ab445624cd4f9c8b161d109f346a9e5ed09a)) - Update doclet to latest version 1.6.0 ([38fb7c3](https://togithub.com/googleapis/java-shared-config/commit/38fb7c3957fb6c9b2da10f9e463cc93a8b80a3a4)) ### [`v1.5.2`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​152-httpsgithubcomgoogleapisjava-shared-configcomparev151v152-2022-07-25) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.1...v1.5.2) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v10 ([#​435](https://togithub.com/googleapis/java-shared-config/issues/435)) ([bfc8ce1](https://togithub.com/googleapis/java-shared-config/commit/bfc8ce1deca6292147d002d3afe22a09840aa5d6)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#​488](https://togithub.com/googleapis/java-shared-config/issues/488)) ([39b91ee](https://togithub.com/googleapis/java-shared-config/commit/39b91ee1283f0a5fbbe63e8bfd1ec97ab4ab377e)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#​489](https://togithub.com/googleapis/java-shared-config/issues/489)) ([cc3bcfa](https://togithub.com/googleapis/java-shared-config/commit/cc3bcfa2d6717441a8d5b5048fa78c2cf7aabf2b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recommender). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
🤖 I have created a release *beep* *boop* --- ## [2.4.4](googleapis/java-accessapproval@v2.4.3...v2.4.4) (2022-08-18) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#793](googleapis/java-accessapproval#793)) ([5cb6e8f](googleapis/java-accessapproval@5cb6e8f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.3.5](https://togithub.com/googleapis/java-iot/compare/v2.3.4...v2.3.5) (2022-10-03) ### Dependencies * Update dependency cachetools to v5 ([#796](https://togithub.com/googleapis/java-iot/issues/796)) ([d9b3568](https://togithub.com/googleapis/java-iot/commit/d9b3568b7b87d1ab6de06b87644ce26e595c5916)) * Update dependency certifi to v2022.9.24 ([#776](https://togithub.com/googleapis/java-iot/issues/776)) ([2060b7a](https://togithub.com/googleapis/java-iot/commit/2060b7a3733e9f64bad0d789bbe666ee79867e28)) * Update dependency charset-normalizer to v2.1.1 ([#780](https://togithub.com/googleapis/java-iot/issues/780)) ([8247c2e](https://togithub.com/googleapis/java-iot/commit/8247c2ebaae5c49d5b96f2f4b6b369f819763b0e)) * Update dependency click to v8.1.3 ([#782](https://togithub.com/googleapis/java-iot/issues/782)) ([1a40780](https://togithub.com/googleapis/java-iot/commit/1a4078092380f72ac574b724a74310afc1ed79b7)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#801](https://togithub.com/googleapis/java-iot/issues/801)) ([f632214](https://togithub.com/googleapis/java-iot/commit/f632214bf0ca879f718d0686d06e5226fbd59307)) * Update dependency gcp-releasetool to v1.8.8 ([#777](https://togithub.com/googleapis/java-iot/issues/777)) ([e7c88de](https://togithub.com/googleapis/java-iot/commit/e7c88dee52268194a44a6596d70a497604a40a4f)) * Update dependency google-api-core to v2.10.1 ([#783](https://togithub.com/googleapis/java-iot/issues/783)) ([8dcbeeb](https://togithub.com/googleapis/java-iot/commit/8dcbeeb32d9866877e6c5de4768e910be5dc494a)) * Update dependency google-auth to v2.12.0 ([#784](https://togithub.com/googleapis/java-iot/issues/784)) ([97cff9c](https://togithub.com/googleapis/java-iot/commit/97cff9ca62475cd0f07a1058052f9df35fdaec77)) * Update dependency google-cloud-core to v2.3.2 ([#778](https://togithub.com/googleapis/java-iot/issues/778)) ([d3acbb8](https://togithub.com/googleapis/java-iot/commit/d3acbb89b2dfdda6e72e2b22762ad5c9629f33c7)) * Update dependency google-cloud-storage to v2.5.0 ([#785](https://togithub.com/googleapis/java-iot/issues/785)) ([2ff55c5](https://togithub.com/googleapis/java-iot/commit/2ff55c561535a01891a1673e456ff489013e5cbb)) * Update dependency google-crc32c to v1.5.0 ([#786](https://togithub.com/googleapis/java-iot/issues/786)) ([11e5f90](https://togithub.com/googleapis/java-iot/commit/11e5f90734aa76ca97119103722ab52357a35f70)) * Update dependency googleapis-common-protos to v1.56.4 ([#779](https://togithub.com/googleapis/java-iot/issues/779)) ([6862333](https://togithub.com/googleapis/java-iot/commit/6862333e490968d778362314a61eb682fba3d843)) * Update dependency importlib-metadata to v4.12.0 ([#787](https://togithub.com/googleapis/java-iot/issues/787)) ([e026a2d](https://togithub.com/googleapis/java-iot/commit/e026a2d6b6d82910fde66c3c8d9be0c2344d6d15)) * Update dependency jeepney to v0.8.0 ([#788](https://togithub.com/googleapis/java-iot/issues/788)) ([e1c303f](https://togithub.com/googleapis/java-iot/commit/e1c303ff87eaab5b8596ee813dcf85be46c63270)) * Update dependency jinja2 to v3.1.2 ([#789](https://togithub.com/googleapis/java-iot/issues/789)) ([7b61752](https://togithub.com/googleapis/java-iot/commit/7b61752378bc542d3a37fa314036b10a6b2bc3b7)) * Update dependency keyring to v23.9.3 ([#790](https://togithub.com/googleapis/java-iot/issues/790)) ([e6a4983](https://togithub.com/googleapis/java-iot/commit/e6a498323d4a1009dab87db1f800202883a58600)) * Update dependency markupsafe to v2.1.1 ([#781](https://togithub.com/googleapis/java-iot/issues/781)) ([3e2ca49](https://togithub.com/googleapis/java-iot/commit/3e2ca493d5868dc2b010541e744d2f76078abfa5)) * Update dependency protobuf to v3.20.2 ([#791](https://togithub.com/googleapis/java-iot/issues/791)) ([925f948](https://togithub.com/googleapis/java-iot/commit/925f948f474c9fdcc7b95b262d294321ee8e71d5)) * Update dependency protobuf to v4 ([#797](https://togithub.com/googleapis/java-iot/issues/797)) ([6d6e582](https://togithub.com/googleapis/java-iot/commit/6d6e582ac17cc0004bb623d25e5ed7900a20ac29)) * Update dependency typing-extensions to v4.3.0 ([#794](https://togithub.com/googleapis/java-iot/issues/794)) ([cf9d81c](https://togithub.com/googleapis/java-iot/commit/cf9d81c1cb08a198f78992ffeaec0eae5a81df1d)) * Update dependency zipp to v3.8.1 ([#795](https://togithub.com/googleapis/java-iot/issues/795)) ([6447b03](https://togithub.com/googleapis/java-iot/commit/6447b039a59d886f568766fb60230e99b5891a40)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…eech to v2.4.9 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-texttospeech](https://togithub.com/googleapis/java-texttospeech) | `2.4.8` -> `2.4.9` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/compatibility-slim/2.4.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/confidence-slim/2.4.8)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-texttospeech). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
…1.4 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-websecurityscanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==-->
🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-core@v2.5.11...v2.6.0) (2022-04-14) ### Features * **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](googleapis/java-core#793)) ([cafd489](googleapis/java-core@cafd489)) * **java:** remove Netty Native Image configuration after relocation to gax ([#771](googleapis/java-core#771)) ([9cc7dba](googleapis/java-core@9cc7dba)) * **java:** remove protobuf Native Image configuration ([#784](googleapis/java-core#784)) ([7a8df66](googleapis/java-core@7a8df66)) * remove native-image.properties settings after relocation ([#794](googleapis/java-core#794)) ([219a519](googleapis/java-core@219a519)) * remove resource-config after relocation ([#795](googleapis/java-core#795)) ([8ed3110](googleapis/java-core@8ed3110)) * remove substitutions after relocation to gax ([#789](googleapis/java-core#789)) ([85280b1](googleapis/java-core@85280b1)) ### Bug Fixes * **java:** register test class for reflection to fix native image test ([#766](googleapis/java-core#766)) ([fa07125](googleapis/java-core@fa07125)) ### Dependencies * revert protobuf to 3.19 and common-protos 2.8.3 ([#798](googleapis/java-core#798)) ([27ca70c](googleapis/java-core@27ca70c)) * update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](googleapis/java-core#800)) ([3abc47d](googleapis/java-core@3abc47d)) * update dependency com.google.api:gax-bom to v2.16.0 ([#785](googleapis/java-core#785)) ([bd33a76](googleapis/java-core@bd33a76)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](googleapis/java-core#792)) ([3f85e62](googleapis/java-core@3f85e62)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](googleapis/java-core#796)) ([d6ea18e](googleapis/java-core@d6ea18e)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](googleapis/java-core#783)) ([48594f3](googleapis/java-core@48594f3)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](googleapis/java-core#799)) ([9fe7d35](googleapis/java-core@9fe7d35)) * update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](googleapis/java-core#788)) ([cfdabb4](googleapis/java-core@cfdabb4)) * update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](googleapis/java-core#791)) ([d9ff405](googleapis/java-core@d9ff405)) * update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](googleapis/java-core#797)) ([dfc3c57](googleapis/java-core@dfc3c57)) * update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](googleapis/java-core#787)) ([51f59fc](googleapis/java-core@51f59fc)) * update dependency io.grpc:grpc-bom to v1.45.1 ([#780](googleapis/java-core#780)) ([cd8a078](googleapis/java-core@cd8a078)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [3.0.3](googleapis/java-shared-dependencies@v3.0.2...v3.0.3) (2022-09-14) ### Dependencies * Google-cloud-core 2.8.12 ([#799](googleapis/java-shared-dependencies#799)) ([1a47f60](googleapis/java-shared-dependencies@1a47f60)) * Moving gson to first-party-dependencies ([#800](googleapis/java-shared-dependencies#800)) ([ceb5fa1](googleapis/java-shared-dependencies@ceb5fa1)) * Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#797](googleapis/java-shared-dependencies#797)) ([57a80c3](googleapis/java-shared-dependencies@57a80c3)) * Update gax.version to v2.19.1 ([#798](googleapis/java-shared-dependencies#798)) ([56ee798](googleapis/java-shared-dependencies@56ee798)) * Update google.core.version to v2.8.11 ([#793](googleapis/java-shared-dependencies#793)) ([ae388d8](googleapis/java-shared-dependencies@ae388d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR adds
ImageId
,ImageInfo
and related test classes.Images can be deprecated using deprecate by passing a
DeprecationStatus
object.This PR also refactors
DeprecationStatus
to add a public builder.Following issue #732 this PR also makes
DeprecationStatus
more tolerant in parsing timestamps (also partial timestamps are supported now).However as per #732 no checks are made on
deleted
,deprecated
andobsolete
timestamps provided to deprecate. If a user misused such fields, creating aDeprecationStatus
might fail. Should we makedeleted
,deprecated
andobsolete
ofString
type? Or keep them ofLong
type and set them tonull
if the string value is not parsable?