Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: samples build fix and docs changes #501

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/5e2a7320-9071-4c7c-b457-b8fc67cdb8f8/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@f68649c
Source-Link: googleapis/synthtool@5f6ef0e

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
Source-Author: Christopher Wilcox <[email protected]>
Source-Date: Thu Oct 22 14:22:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5f6ef0ec5501d33c4667885b37a7685a30d41a76
Source-Link: googleapis/synthtool@5f6ef0e
Fixes below error in Java repos when googleapis/synthtool#804 was merged:
```
github/java-bigquerystorage/.kokoro/build.sh: line 81: pushd: {SAMPLES_DIR}: No such file or directory
```

Thanks @kolea2 for spotting this in Fusion build logs.

cc @chingor13

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Oct 26 13:44:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: f68649c5f26bcff6817c6d21e90dac0fc71fef8e
Source-Link: googleapis/synthtool@f68649c
@yoshi-automation yoshi-automation requested review from a team as code owners October 27, 2020 08:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #501 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
+ Coverage     81.31%   81.35%   +0.04%     
  Complexity     1128     1128              
============================================
  Files           106      106              
  Lines          7042     7042              
  Branches        368      368              
============================================
+ Hits           5726     5729       +3     
+ Misses         1119     1116       -3     
  Partials        197      197              
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 60.65% <0.00%> (+0.81%) 14.00% <0.00%> (ø%)
...oud/bigtable/data/v2/models/DefaultRowAdapter.java 100.00% <0.00%> (+3.12%) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0809d8f...aa2455b. Read the comment docs.

@kolea2 kolea2 changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. chore: samples build fix and docs changes Oct 27, 2020
@kolea2 kolea2 merged commit e1eb7ba into master Oct 27, 2020
@kolea2 kolea2 deleted the autosynth-synthtool branch October 27, 2020 14:35
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* chore(docs): update code of conduct of synthtool and templates

Source-Author: Christopher Wilcox <[email protected]>
Source-Date: Thu Oct 22 14:22:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5f6ef0ec5501d33c4667885b37a7685a30d41a76
Source-Link: googleapis/synthtool@5f6ef0e

* chore(ci): fix typo in restrict presubmit samples ITs to only snapshot

Fixes below error in Java repos when googleapis/synthtool#804 was merged:
```
github/java-bigquerystorage/.kokoro/build.sh: line 81: pushd: {SAMPLES_DIR}: No such file or directory
```

Thanks @kolea2 for spotting this in Fusion build logs.

cc @chingor13

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Oct 26 13:44:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: f68649c5f26bcff6817c6d21e90dac0fc71fef8e
Source-Link: googleapis/synthtool@f68649c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants