-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric #2030
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This and it seems owl is still failing. |
@yirutang tnx for getting back to this. What error is the owl bot running into? I can confirm that this PR allows edits from maintainers (see below screenshot) |
I rerun both tasks and owl is still failing, I am asking java lib owner to take a look. |
Hi @rdebokx , My suggestion is to create a new PR from a fork directly from this repo. Or I could duplicate this PR, but that would mean you don't get the commit in your name. I would prefer you open the PR again, that way you get the credit that's due. Let me know how you want to proceed and thanks for contributing. |
Thanks again for looking into this @Neenu1995 . I've created a fresh fork from my work account (but not as organization), and recreated the PR: #2031 Hopefully this will solve the issue. |
Fixes #2013