Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric #2019

Closed
wants to merge 1 commit into from
Closed

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric #2019

wants to merge 1 commit into from
+29 −6

Conversation

roy-tc
Copy link
Contributor

@roy-tc roy-tc commented Feb 27, 2023

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2013

@roy-tc roy-tc requested review from a team and Neenu1995 February 27, 2023 10:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Feb 27, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2023
@yirutang
Copy link
Contributor

yirutang commented Mar 2, 2023 •
edited
Loading

Hi Roy, could you enable edits on your branch by the maintainers((including the postprocessor, who tries to update pull requests), so that the owl process can proceed?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@roy-tc
Copy link
Contributor Author

roy-tc commented Mar 3, 2023

Hi @yirutang , tnx for reaching out.
It turned out that this was not possible to do from an organization repository. I recreated the PR from my personal account here: #2030
This should allow edits by maintainers.

@roy-tc roy-tc closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery Storage Write API: JsonStreamWriter cannot transform BigDecimal with 9+ decimals to BigNumeric
4 participants
@roy-tc @yirutang @Neenu1995 @yoshi-kokoro