Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric #2031

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric #2031

merged 2 commits into from
Mar 8, 2023

Conversation

roy-tc
Copy link
Contributor

@roy-tc roy-tc commented Mar 8, 2023

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2013

@roy-tc roy-tc requested review from a team and chalmerlowe March 8, 2023 08:51
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 8, 2023
@rdebokx rdebokx mentioned this pull request Mar 8, 2023
Closed
4 tasks
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner March 8, 2023 15:17
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@Neenu1995
Copy link
Contributor

Hi @roy-tc ,

That worked!
Thanks again for contributing.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@roy-tc
Copy link
Contributor Author

roy-tc commented Mar 8, 2023

Thanks for the efforts @Neenu1995 ! Looking forward to the release.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit e0f7e34 into googleapis:main Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
@release-please release-please bot mentioned this pull request Mar 9, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 13, 2023
@release-please
chore(main): release 2.34.0 (#2033)
40ac0bf 
🤖 I have created a release *beep* *boop*
---


## [2.34.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.33.1...v2.34.0) (2023-03-10)


### Features

* Add routing header for multiplexed connection ([#2035](https://togithub.com/googleapis/java-bigquerystorage/issues/2035)) ([1f2752f](https://togithub.com/googleapis/java-bigquerystorage/commit/1f2752f3988ac87dca50813d69d0d519a2356a30))


### Bug Fixes

* **bigdecimal:** Convert BigDecimal to BigNumeric instead of Numeric ([#2031](https://togithub.com/googleapis/java-bigquerystorage/issues/2031)) ([e0f7e34](https://togithub.com/googleapis/java-bigquerystorage/commit/e0f7e34ca7f7c60279985afec46f780e0acc9a9e)), closes [#2013](https://togithub.com/googleapis/java-bigquerystorage/issues/2013)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this pull request Mar 22, 2023
@release-please @yirutang
chore(main): release 2.34.0 (googleapis#2033)
3bbb143 
🤖 I have created a release *beep* *boop*
---


## [2.34.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.33.1...v2.34.0) (2023-03-10)


### Features

* Add routing header for multiplexed connection ([googleapis#2035](https://togithub.com/googleapis/java-bigquerystorage/issues/2035)) ([1f2752f](https://togithub.com/googleapis/java-bigquerystorage/commit/1f2752f3988ac87dca50813d69d0d519a2356a30))


### Bug Fixes

* **bigdecimal:** Convert BigDecimal to BigNumeric instead of Numeric ([googleapis#2031](https://togithub.com/googleapis/java-bigquerystorage/issues/2031)) ([e0f7e34](https://togithub.com/googleapis/java-bigquerystorage/commit/e0f7e34ca7f7c60279985afec46f780e0acc9a9e)), closes [googleapis#2013](https://togithub.com/googleapis/java-bigquerystorage/issues/2013)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery Storage Write API: JsonStreamWriter cannot transform BigDecimal with 9+ decimals to BigNumeric
3 participants
@roy-tc @Neenu1995 @yoshi-kokoro