-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add routing header for multiplexed connection #2035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
labels
Mar 10, 2023
yirutang
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 10, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 10, 2023
GaoleMeng
reviewed
Mar 10, 2023
} else { | ||
newHeaders.put( | ||
"x-goog-request-params", | ||
"write_location=" + getRoutingHeader(this.streamName, this.location)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check on whether it's empty
GaoleMeng
approved these changes
Mar 10, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
🤖 I have created a release *beep* *boop* --- ## [2.34.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.33.1...v2.34.0) (2023-03-10) ### Features * Add routing header for multiplexed connection ([#2035](https://togithub.com/googleapis/java-bigquerystorage/issues/2035)) ([1f2752f](https://togithub.com/googleapis/java-bigquerystorage/commit/1f2752f3988ac87dca50813d69d0d519a2356a30)) ### Bug Fixes * **bigdecimal:** Convert BigDecimal to BigNumeric instead of Numeric ([#2031](https://togithub.com/googleapis/java-bigquerystorage/issues/2031)) ([e0f7e34](https://togithub.com/googleapis/java-bigquerystorage/commit/e0f7e34ca7f7c60279985afec46f780e0acc9a9e)), closes [#2013](https://togithub.com/googleapis/java-bigquerystorage/issues/2013) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
yirutang
pushed a commit
to yirutang/java-bigquerystorage
that referenced
this pull request
Mar 22, 2023
🤖 I have created a release *beep* *boop* --- ## [2.34.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.33.1...v2.34.0) (2023-03-10) ### Features * Add routing header for multiplexed connection ([googleapis#2035](https://togithub.com/googleapis/java-bigquerystorage/issues/2035)) ([1f2752f](https://togithub.com/googleapis/java-bigquerystorage/commit/1f2752f3988ac87dca50813d69d0d519a2356a30)) ### Bug Fixes * **bigdecimal:** Convert BigDecimal to BigNumeric instead of Numeric ([googleapis#2031](https://togithub.com/googleapis/java-bigquerystorage/issues/2031)) ([e0f7e34](https://togithub.com/googleapis/java-bigquerystorage/commit/e0f7e34ca7f7c60279985afec46f780e0acc9a9e)), closes [googleapis#2013](https://togithub.com/googleapis/java-bigquerystorage/issues/2013) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.