Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

cleanup: remove migrated sample #1137

Merged
merged 6 commits into from
Jan 4, 2023
Merged

cleanup: remove migrated sample #1137

merged 6 commits into from
Jan 4, 2023

Conversation

Shabirmean
Copy link
Member

Remove the sample that was migrated in GoogleCloudPlatform/java-docs-samples#7451

@Shabirmean Shabirmean requested review from a team as code owners November 18, 2022 23:39
@snippet-bot
Copy link

snippet-bot bot commented Nov 18, 2022 •
edited
Loading

Here is the summary of changes.

You are about to delete 115 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. labels Nov 18, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@Shabirmean Shabirmean added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 18, 2022
Sita04
Sita04 approved these changes Dec 15, 2022
View reviewed changes
Copy link

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, post migration PR merge.

@Shabirmean Shabirmean added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 21, 2022
@Shabirmean Shabirmean added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 4, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 4, 2023
@Shabirmean Shabirmean merged commit d4f354c into main Jan 4, 2023
@Shabirmean Shabirmean deleted the fixit/sample-migration branch January 4, 2023 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@Sita04 Sita04 Sita04 approved these changes

Assignees

@Sita04 Sita04

Labels
api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shabirmean @Sita04 @meltsufin @yoshi-kokoro