Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #833 - Failing test due to querystring order. #834

Merged
merged 1 commit into from
Apr 16, 2015

Conversation

jgeewax
Copy link
Contributor

@jgeewax jgeewax commented Apr 16, 2015

Fixes #833

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2015
@jgeewax jgeewax added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. testing labels Apr 16, 2015
@jgeewax jgeewax added this to the Storage Stable milestone Apr 16, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 37f22dc on jgeewax:url-param-order into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor

dhermes commented Apr 16, 2015

LGTM Thanks

@tseaver
Copy link
Contributor

tseaver commented Apr 16, 2015

Yup

@jgeewax
Copy link
Contributor Author

jgeewax commented Apr 16, 2015

Sweet. Just saw the build pass (and I fixed this to follow the pattern you guys had using six.moves). Merging.

jgeewax added a commit that referenced this pull request Apr 16, 2015
Fix #833 - Failing test due to querystring order.
@jgeewax jgeewax merged commit 40d84e9 into googleapis:master Apr 16, 2015
@jgeewax jgeewax deleted the url-param-order branch April 16, 2015 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing build due to order of url params?
5 participants