Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing build due to order of url params? #833

Closed
jgeewax opened this issue Apr 16, 2015 · 1 comment · Fixed by #834
Closed

Failing build due to order of url params? #833

jgeewax opened this issue Apr 16, 2015 · 1 comment · Fixed by #834
Assignees
@jgeewax
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Apr 16, 2015

Build: https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/58770268
Full log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/58770269/log.txt

Snippet that I think matters:

Traceback (most recent call last):
  File "/home/travis/build/GoogleCloudPlatform/gcloud-python/gcloud/storage/test_api.py", line 153, in test_non_use_default
    self._list_buckets_non_empty_helper('PROJECT', use_default=True)
  File "/home/travis/build/GoogleCloudPlatform/gcloud-python/gcloud/storage/test_api.py", line 147, in _list_buckets_non_empty_helper
    self.assertEqual(http._called_with['uri'], URI)
AssertionError: 'https://www.googleapis.com/storage/v1/b?project=PROJECT&projection=noAcl' != 'https://www.googleapis.com/storage/v1/b?projection=noAcl&project=PROJECT'
- https://www.googleapis.com/storage/v1/b?project=PROJECT&projection=noAcl
?                                                ----------------
+ https://www.googleapis.com/storage/v1/b?projection=noAcl&project=PROJECT

Guessing we should parse the URL params and compare dictionaries instead of doing a string comparison?
@jgeewax jgeewax added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Apr 16, 2015
@jgeewax jgeewax added this to the Core Stable milestone Apr 16, 2015
jgeewax added a commit to jgeewax/gcloud-python that referenced this issue Apr 16, 2015
@jgeewax
Fix googleapis#833 - Failing test due to querystring order.
26ac88b
jgeewax added a commit to jgeewax/gcloud-python that referenced this issue Apr 16, 2015
@jgeewax
Fix googleapis#833 - Failing test due to querystring order.
d53906e
@jgeewax jgeewax mentioned this issue Apr 16, 2015
Merged
jgeewax added a commit to jgeewax/gcloud-python that referenced this issue Apr 16, 2015
@jgeewax
Fix googleapis#833 - Failing test due to querystring order.
37f22dc
@dhermes
Copy link
Contributor

dhermes commented Apr 16, 2015

Yeah I noticed the failure yesterday. It's very strange we've never seen it happen, we thought we covered them all.

jgeewax added a commit that referenced this issue Apr 16, 2015
@jgeewax
Merge pull request #834 from jgeewax/url-param-order
40d84e9 
Fix #833 - Failing test due to querystring order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgeewax jgeewax

Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #833 - Failing test due to querystring order. jgeewax/gcloud-python
2 participants
@jgeewax @dhermes