Making it impossible to call Policy.open() on an already opened policy.
#4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
changed the title
Policy.open() on an already opened pol…Policy.open() on an already opened policy.
dhermes
commented
Dec 16, 2017
| @@ -159,7 +174,7 @@ def close(self): | |||
|
|
|||
| # The subscription is closing cleanly; resolve the future if it is not | |||
| # resolved already. | |||
| if self._future is not None and not self._future.done(): | |||
| if not self._future.done(): | |||
| self._future.set_result(None) | |||
| self._future = None | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Dec 16, 2017
|
I'll hold off on merging until we can chat about the possibility of returning the "removed" future in |
chemelnucfin
added
do not close
do not merge
…icy. Similar with `Policy.close()`. Fixes googleapis#4488.
dhermes
removed
do not close
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar with
Policy.close().Fixes #4488.