Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple calls to Pub/Sub Policy.open() can "interact" #4488

Closed
dhermes opened this issue Nov 29, 2017 · 0 comments · Fixed by #4606
Closed

Multiple calls to Pub/Sub Policy.open() can "interact" #4488

dhermes opened this issue Nov 29, 2017 · 0 comments · Fixed by #4606
Assignees
@dhermes
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@dhermes
Copy link
Contributor

dhermes commented Nov 29, 2017 •
edited
Loading

E.g. if you call Policy.open() a second time then it will overwrite the callback attached to the Policy.

ISTM that we should "tombstone" a Policy so that it can't be open()-ed more than once.
@dhermes dhermes added api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Nov 29, 2017
@dhermes dhermes changed the title Multiple calls to Policy.open() can "interact" Multiple calls to Pub/Sub Policy.open() can "interact" Nov 29, 2017
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 16, 2017
@dhermes
Making it impossible to call Policy.open() on an already opened pol…
d1c6667 
…icy.

Similar with `Policy.close()`.

Fixes googleapis#4488.
@dhermes dhermes mentioned this issue Dec 16, 2017
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 18, 2017
@dhermes
Making it impossible to call Policy.open() on an already opened pol…
b547859 
…icy.

Similar with `Policy.close()`.

Fixes googleapis#4488.
dhermes added a commit that referenced this issue Dec 18, 2017
@dhermes
Making it impossible to call Policy.open() on an already opened pol…
1a37fce 
…icy. (#4606)

Similar with `Policy.close()`.

Fixes #4488.

Also returning the future from `Policy.close()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Making it impossible to call Policy.open() on an already opened policy. dhermes/google-cloud-python
1 participant
@dhermes