Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs for the Runtime Config API. #2689

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 4, 2016

The runtimeconfig-usage doc (or the runtimeconfig/google/cloud/runtimeconfig/__init__.py file) should add some examples of library usage.

@tswast once this is merged, care to take the reins on adding some usage examples?

The runtimeconfig-usage doc (or the
`runtimeconfig/google/cloud/runtimeconfig/__init__.py`
file) should add some examples of library usage.
@dhermes dhermes added docs api: runtimeconfig Issues related to the Cloud Runtime Config API API. labels Nov 4, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Nov 4, 2016

Note the only failure here has been resolved in #2020, which @daspecster just merged. This is good to merge if anyone can review.

Copy link
Contributor

@daspecster daspecster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just the one question.

@@ -0,0 +1,6 @@
Variables
~~~~~~~~~

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes merged commit 7e2eb33 into googleapis:master Nov 4, 2016
@dhermes dhermes deleted the add-runtimeconfig-docs branch November 4, 2016 20:21
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: runtimeconfig Issues related to the Cloud Runtime Config API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants