Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change [pep8]-> [pycodestyle] in tox.ini #2020

Merged
merged 3 commits into from
Nov 4, 2016
Merged

Change [pep8]-> [pycodestyle] in tox.ini #2020

merged 3 commits into from
Nov 4, 2016

Conversation

daspecster
Copy link
Contributor

@daspecster daspecster commented Jul 22, 2016 •
edited
Loading

Here's an example of what I was talking about in #2019 (comment).

pycodestyle reference: PyCQA/pycodestyle#550

@daspecster daspecster added hygiene do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 22, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2016
This was referenced Jul 22, 2016
Merged
Merged
@daspecster
Copy link
Contributor Author

I deleted the cache on travis for this PR too. No dice.

@dhermes
Copy link
Contributor

dhermes commented Jul 25, 2016

Is there documentation to support either syntax?

@daspecster
Copy link
Contributor Author

daspecster commented Jul 25, 2016 •
edited
Loading

screen shot 2016-07-25 at 5 12 23 pm

From: http://pep8.readthedocs.io/en/latest/intro.html#configuration

Travis says it's pulling in pycodestyle=2.0.0 AFAICT.

@dhermes
Copy link
Contributor

dhermes commented Jul 25, 2016

👍

@daspecster daspecster mentioned this pull request Jul 25, 2016
Closed
@daspecster
Copy link
Contributor Author

pycodestyle still hasn't cut a release yet.

@dhermes
Copy link
Contributor

dhermes commented Aug 17, 2016

Refresh me, what is the release we're waiting for

@daspecster
Copy link
Contributor Author

Supporting [pycodestyle] in the config instead of [pep8].

On Wed, Aug 17, 2016 at 2:30 PM, Danny Hermes [email protected]
wrote:

Refresh me, what is the release we're waiting for

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALvyKLNTlabyMiswmQILZLb-6OAr05Kks5qg1MqgaJpZM4JTL4U
.

Tom Schultz

@dhermes
Copy link
Contributor

dhermes commented Aug 17, 2016

Ah. Shucks.

@daspecster
Copy link
Contributor Author

Should get a release for this soon! PyCQA/pycodestyle#574 (comment)

@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2016

Ugh, THAT NO WORK!

@daspecster
Copy link
Contributor Author

@tseaver, Yeah not until they cut the release. They updated on their master branch a while ago but that change hasn't been pushed to pypi.

When they cut the release I'll start travis and it should just go green.

@daspecster daspecster mentioned this pull request Oct 3, 2016
Closed
@daspecster
Copy link
Contributor Author

Pycodestyle 2.1.0!
https://github.com/PyCQA/pycodestyle/releases/tag/2.1.0

@dhermes
Copy link
Contributor

dhermes commented Nov 4, 2016

@daspecster You need a version lower bound: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/75e46139695747ddd1bbbc8cd3841bb6897331c8/tox.ini#L214

@daspecster
Copy link
Contributor Author

@dhermes b8d6ed6

@dhermes
Copy link
Contributor

dhermes commented Nov 4, 2016

LGTM pending Travis

@dhermes
Copy link
Contributor

dhermes commented Nov 4, 2016

Actually @daspecster it looks like the new version of pycodestyle picked up something it didn't before:

scripts/generate_json_docs.py:656:1: E305 expected 2 blank lines after class or function definition, found 1

Can you add an extra empty line before the if __name__ == '__main__' in that file?

@dhermes
Copy link
Contributor

dhermes commented Nov 4, 2016

@daspecster LGTM to merge on Travis green. Also, is the don't merge label still relevant?

@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2016
@daspecster
Copy link
Contributor Author

Ok cool. Nope, forgot it was there.

@daspecster daspecster merged commit fe4ef3c into googleapis:master Nov 4, 2016
@daspecster daspecster deleted the tox-pycodestyle-config branch November 4, 2016 19:59
@dhermes dhermes mentioned this pull request Nov 4, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2020 from daspecster/tox-pycodestyle-co…
21c169d 
…nfig

Change [pep8]-> [pycodestyle] in tox.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @dhermes @tseaver @googlebot