Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for 'Sink.create', w/ Storage bucket destination #1628

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Add system test for 'Sink.create', w/ Storage bucket destination #1628

merged 1 commit into from
Mar 22, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 17, 2016

Uses #1613 as a base.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2016
@tseaver tseaver changed the title Add system test for 'Sink.create'. Add system test for 'Sink.create', w/ Storage bucket destination Mar 17, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

LGTM pending rebase.

Also, FWIW if you rebase both this and #1613, then merge this, then GitHub will auto-close #1613 as merged.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 18, 2016

N.B. that we cannot merge this PR until we have solved the problem outlined in #1614 (system tests have to run as a user with permission to create / update / delete sinks, i.e. with Owner role).

@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

Noted

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 18, 2016
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 22, 2016
tseaver added a commit that referenced this pull request Mar 22, 2016
Add system test for 'Sink.create', w/ Storage bucket destination
@tseaver tseaver merged commit 0adbd70 into googleapis:logging-api Mar 22, 2016
@tseaver tseaver deleted the logging-system_test-sink_create branch March 22, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants