Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for 'Metric.update'. #1613

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Add system test for 'Metric.update'. #1613

merged 1 commit into from
Mar 18, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 15, 2016

Uses #1612 as a base.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

LGTM pending a rebase.

@tseaver tseaver self-assigned this Mar 18, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 18, 2016

@dhermes Rebased after merging #1612. Unless you object, I will merge as soon as Travis passes.

@tseaver tseaver assigned dhermes and unassigned tseaver Mar 18, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

LGTM still valid

@tseaver
Copy link
Contributor Author

tseaver commented Mar 18, 2016

Dunno why Travis is not re-running after the rebase.

tseaver added a commit that referenced this pull request Mar 18, 2016
@tseaver tseaver merged commit 303f2a8 into googleapis:logging-api Mar 18, 2016
@tseaver tseaver deleted the logging-system_test-metric_update branch March 18, 2016 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants