Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use ubuntu 22.04 for tests #13377

Merged
merged 4 commits into from
Dec 19, 2024
Merged

build: use ubuntu 22.04 for tests #13377

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ed4364
build: use ubuntu 22.04 for tests
parthea Dec 19, 2024
510d62d
test
parthea Dec 19, 2024
18e7b63
Revert "test"
parthea Dec 19, 2024
84387ef
Add TODO comment
parthea Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ permissions:

jobs:
unit:
runs-on: ubuntu-latest
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2303): use `ubuntu-latest` once this bug is fixed.
# Use ubuntu-22.04 until Python 3.7 is removed from the test matrix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a TODO and link to an umbrella issue for this? A quick search suggests the only currently filed issue for the 3.7 deprecation is #11437, but that deals more with messaging the deprecation. We should have an issue for actually removing support when the time comes, and part of that should be removing this Ubuntu specification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 84387ef

# https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
runs-on: ubuntu-22.04
strategy:
matrix:
python: ['3.7', '3.8', '3.9', '3.10', "3.11", "3.12", "3.13"]
Expand Down
Loading